Checklist for frontend code review
What you look for before code is merged in
§Structure and readability
- 01Is the HTML semantic and are the headings in logical order?
- 02Are structure, style and logic kept separate?
- 03Are names of variables and functions meaningful?
- 04Is there dead or commented-out code that should be removed?
§Accessibility
- 01Can the new one be operated with a keyboard alone?
- 02Do images have meaningful alternative text, and are decorative images marked?
- 03Do form fields have clear labels?
- 04Is there sufficient contrast and is colour not used as the only signal?
§Responsive and performance
- 01Does it look right on both small and large screens?
- 02Do images and media scale with their container?
- 03Are there unnecessary heavy or duplicate resources?
§Robustness and safety
- 01Are errors and waiting times during data retrieval handled reasonably?
- 02Is input validated and checked on the server?
- 03Is there no access credentials or secrets in the frontend code?
- 04Does it work in multiple browsers?